How we review pull requests, so feedback is fast, consistent, and never personal.
Read the description before the diff. If the approach is wrong, line comments on the implementation are wasted effort.
Aim for a same-day first pass. A PR that sits ignored for days is worse for morale than an imperfect one merged quickly.
"Consider X because Y" invites a conversation. "Change this" invites a fight. Say why, not just what.
| PR size | First response |
|---|---|
| Under 100 lines | Within 2 hours |
| 100–400 lines | Same day |
| Over 400 lines | Ask the author to split it first |
Approve with comments beats blocking. If nothing you've flagged would stop this from working in production, approve it and let the author decide.